Simplify the code that resets the value of the pageNumber element in PDFViewerApplication.setInitialView
#6199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n `PDFViewerApplication.setInitialView` After the creation of `PDFViewer`, its `_resetView` method takes care of resetting, among other things, the page number property. Hence we don't need to set `pdfViewer.currentPageNumber = 1;` here any more, and the comment is no longer accurate either.
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/1b67e105e91afb0/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/1b67e105e91afb0/output.txt Total script time: 1.03 mins Published |
timvandermeij
added a commit
that referenced
this pull request
Jul 12, 2015
…pler-pageNumber-reset Simplify the code that resets the value of the `pageNumber` element in `PDFViewerApplication.setInitialView`
|
Looks good, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another very small piece of
viewer.jsclean-up.After the creation of
PDFViewer, its_resetViewmethod takes care of resetting, among other things, the page number property. Hence we don't need to setpdfViewer.currentPageNumber = 1;here any more, and the comment is no longer accurate either.