Move handling of the 'custom' scale value from pdf_viewer.js to viewer.js #6235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r.js The special handling of the 'custom' scale value is only relevant for the `scaleSelect` dropdown in the standard viewer, hence I think that it should be placed in `viewer.js` instead.
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/5d7a21edab2f042/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/5d7a21edab2f042/output.txt Total script time: 0.98 mins Published |
timvandermeij
added a commit
that referenced
this pull request
Jul 20, 2015
Move handling of the 'custom' scale value from pdf_viewer.js to viewer.js
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The special handling of the 'custom' scale value is only relevant for the
scaleSelectdropdown in the standard viewer, hence I think that it should be placed inviewer.jsinstead.Another small round of viewer clean-up. @timvandermeij would you mind reviewing this?