Fix a regression, from PR 5356, that breaks all scrolling in PresentationMode #6524
Conversation
…tionMode *This regressed in PR 5356.* Rather than just backing out the offending code, this patch restores scrolling in PresentationMode by making the `overflow: hidden;` check optional and letting the callers that need it (e.g. `PDFFindController`) opt-in to use it.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/1465e3324dcc0c5/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/1465e3324dcc0c5/output.txt Total script time: 0.64 mins Published |
| * @param {Object} element - The element to be visible. | ||
| * @param {Object} spot - An object with optional top and left properties, | ||
| * specifying the offset from the top left edge. | ||
| * @param {boolean} skipOverflowHiddenElements - Ignore elements that have |
There was a problem hiding this comment.
For clarity Ignore elements... should probably be Ignore DOM elements... instead.
@timvandermeij If you agree, I'll push an updated patch!
There was a problem hiding this comment.
I actually think that's clear enough (especially from the overflow:hidden part, which indicates DOM elements), but if you want you can always create a new PR to improve the comment.
There was a problem hiding this comment.
If you think this is fine, I won't bother changing it now that the PR has already landed.
Thanks for reviewing/merging :-)
|
I can confirm that this fixes both scrolling in presentation mode and the original issue that Rob's PR fixed. The code is also cleaner in my opinion. Thank you! |
…ng-regression-fix Fix a regression, from PR 5356, that breaks all scrolling in PresentationMode
This regressed in PR #5356.
Rather than just backing out the offending code, this patch restores scrolling in PresentationMode by making the
overflow: hidden;check optional and letting the callers that need it (e.g.PDFFindController) opt-in to use it.