Move VIEW_HISTORY_MEMORY constant to view_history.js

[timvandermeij]

Currently this constant is present in viewer.js, but it is not used there at all. Instead, it is used in view_history.js where we have a global for it. We might as well move the constant to view_history.js as that is the only place where it is used, thereby removing a global and an unused constant from viewer.js.

[timvandermeij]

It took a while, but I finally had a bit of time to create a new patch. @Snuffleupagus Could you review this one if you have time?

[Snuffleupagus]

If you're touching this code anyway, I'm wondering if we should take it a bit further by making the size configurable when initializing ViewHistory? E.g. something like this:

• in view_history.js, change function ViewHistory(fingerprint) { to function ViewHistory(fingerprint, size) {.
• define var cacheSize = size || DEFAULT_VIEW_HISTORY_SIZE; (if we're doing this, a slight rename of the constant might be in order), and compare the length against that value at view_history.js#L42.

@timvandermeij How do you feel about the above?

[timvandermeij]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/946f6bfc082e149/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/946f6bfc082e149/output.txt

Total script time: 0.75 mins

Published

• Viewer: http://107.21.233.14:8877/946f6bfc082e149/web/viewer.html
• B2G Viewer: http://107.21.233.14:8877/946f6bfc082e149/extensions/b2g/content/web/viewer.html
• Extension: http://107.21.233.14:8877/946f6bfc082e149/extensions/firefox/pdf.js.xpi

[timvandermeij]

@Snuffleupagus I have implemented that in the second commit. It seems like a good addition to me too. Note that I have kept the commits separate on purpose as the first one is just moving code and the second one is adding new functionality. For the sake of consistency I did not use var cacheSize, but this.cacheSize instead as that has also been done for the fingerprint in the code (and it seems good to make this a class variable).

Could you check this patch again?

[Snuffleupagus]

Looks good, thanks for the clean-up!