Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the unavailable linked test-case for issue 2128 with a reduced test-case #6610

Merged
merged 1 commit into from
Nov 11, 2015
Merged

Replace the unavailable linked test-case for issue 2128 with a reduced test-case #6610

merged 1 commit into from
Nov 11, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

Re: issue #2128 and PR #2628.

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Nov 9, 2015

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/8847ea8a5376276/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 9, 2015

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/95b107ace06ecf3/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 9, 2015

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/8847ea8a5376276/output.txt

Total script time: 19.02 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/8847ea8a5376276/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Nov 9, 2015

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/95b107ace06ecf3/output.txt

Total script time: 19.91 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/95b107ace06ecf3/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

There appears to be something wrong with the test on Linux. The characters are all replaced with squares. @Snuffleupagus Do you have an idea why that is happening only on Linux?

@Snuffleupagus
Copy link
Collaborator Author

Do you have an idea why that is happening only on Linux?

Not really, since it works as expected on Windows. My only idea is that this might be a pre-existing issue on Linux, so I've just submitted a temporary patch to test that idea.

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Nov 9, 2015

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/26f0156b75321f4/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 9, 2015

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/790ae8bc6cc253f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 9, 2015

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/26f0156b75321f4/output.txt

Total script time: 1.34 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/26f0156b75321f4/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Nov 9, 2015

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/790ae8bc6cc253f/output.txt

Total script time: 1.57 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/790ae8bc6cc253f/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

My only idea is that this might be a pre-existing issue on Linux, so I've just submitted a temporary patch to test that idea.

The last round of testing seem to confirm this theory.
@timvandermeij Since this is an existing issue, would you agree that the PR is good to go (once the temporary test commit is removed)?

@timvandermeij
Copy link
Contributor

I have opened the issue above to track the Linux problem. Otherwise this patch seems fine to me and Yury confirmed on IRC that we can go ahead and merge this.

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/9ad9e39fd657571/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/c5a9689e0d8dc4c/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/9ad9e39fd657571/output.txt

Total script time: 18.80 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/c5a9689e0d8dc4c/output.txt

Total script time: 20.30 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

timvandermeij added a commit that referenced this pull request Nov 11, 2015
Replace the unavailable linked test-case for issue 2128 with a reduced test-case
@timvandermeij timvandermeij merged commit 3a23367 into mozilla:master Nov 11, 2015
@timvandermeij
Copy link
Contributor

Thank you for this patch!

@Snuffleupagus Snuffleupagus deleted the issue-2128-reduced-test branch November 11, 2015 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants