-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly handle /FitH destinations with null
as the parameter
#6617
Conversation
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/3d99c23434f4278/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/3d99c23434f4278/output.txt Total script time: 1.19 mins Published |
@@ -519,6 +519,12 @@ var PDFViewer = (function pdfViewer() { | |||
case 'FitBH': | |||
y = dest[2]; | |||
scale = 'page-width'; | |||
// According to the PDF specification, a `null` value in the parameter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer to the specific section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
According to http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G11.2095870, the vertical position shouldn't change if the parameter is `null`. Fixes 6615.
LGTM 👍, I verified that the patch fixes #6615. |
Correctly handle /FitH destinations with `null` as the parameter
Thank you. |
According to http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G11.2095870, the vertical position shouldn't change if the parameter is
null
.Fixes #6615.