Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of Util.inherit in src/core/pdf_manager.js #6701

Merged
merged 1 commit into from
Dec 1, 2015

Conversation

timvandermeij
Copy link
Contributor

While we are here, fix some incorrect function names.

@Snuffleupagus Are you up for reviewing this one too? If not, feel free to unassign yourself.

Tip: use the ?w=1 flag to make review easier.

While we are here, fix some incorrect function names.
@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/f749347b99e2ca9/output.txt

@timvandermeij
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/1b543e674e8ee8e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/21989e73c7bf66c/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/1b543e674e8ee8e/output.txt

Total script time: 18.83 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/21989e73c7bf66c/output.txt

Total script time: 19.62 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

Snuffleupagus added a commit that referenced this pull request Dec 1, 2015
Make use of `Util.inherit` in `src/core/pdf_manager.js`
@Snuffleupagus Snuffleupagus merged commit 5f56a20 into mozilla:master Dec 1, 2015
@Snuffleupagus
Copy link
Collaborator

Looks good, thank you!

@timvandermeij timvandermeij deleted the pdf-manager-inherit branch December 1, 2015 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants