-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of Util.inherit
in src/core/pdf_manager.js
#6701
Make use of Util.inherit
in src/core/pdf_manager.js
#6701
Conversation
While we are here, fix some incorrect function names.
c9300cb
to
0c41866
Compare
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/f749347b99e2ca9/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/f749347b99e2ca9/output.txt Total script time: 0.76 mins Published |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/1b543e674e8ee8e/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/21989e73c7bf66c/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/1b543e674e8ee8e/output.txt Total script time: 18.83 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/21989e73c7bf66c/output.txt Total script time: 19.62 mins
|
Make use of `Util.inherit` in `src/core/pdf_manager.js`
Looks good, thank you! |
While we are here, fix some incorrect function names.
@Snuffleupagus Are you up for reviewing this one too? If not, feel free to unassign yourself.
Tip: use the
?w=1
flag to make review easier.