Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect position of text widget #6758

Merged
merged 1 commit into from Dec 15, 2015

Conversation

xlc
Copy link
Contributor

@xlc xlc commented Dec 15, 2015

While working on rebasing #6172 found this bug.
I think it is regression from #6714

Testing file: https://drive.google.com/file/d/0B6YhVF9p-y2AYmtDbGxUX2lUQkE/view?usp=sharing

Before: (Note the position of text 123)
screen shot 2015-12-16 at 11 25 32 am

After:
screen shot 2015-12-16 at 11 25 51 am

@timvandermeij
Copy link
Contributor

Thank you for reporting this. In my opinion the underlying issue is indeed that the code creates its own container instead of using the getContainer function like the other annotation types, which you address in this PR. It is somewhat of a regression as my PR made this issue visible because it was previously fixed in the web/annotations_layer_builder.js layer whereas it is now all taken care of in the getContainer function in src/display/annotation_layer.js.

I will add this PDF file to my local test suite, which I use for each of my annotation PRs, to avoid future regressions. An advantage of this patch is that it provides some nice code cleanup and more consistency with the other functions.

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/49213697213c4a2/output.txt

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/b38e49222e5233b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/48c4e5fec5896b4/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/48c4e5fec5896b4/output.txt

Total script time: 19.49 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/b38e49222e5233b/output.txt

Total script time: 19.66 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

timvandermeij added a commit that referenced this pull request Dec 15, 2015
Fix incorrect position of text widget
@timvandermeij timvandermeij merged commit a1aec82 into mozilla:master Dec 15, 2015
@timvandermeij
Copy link
Contributor

Awesome, looks good!

@xlc xlc deleted the fix-text-widget branch December 16, 2015 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants