Remove a superfluous "s" in AnnotationsLayerBuilder from files in web/
#6772
Conversation
| @@ -47,7 +47,7 @@ PDFJS.getDocument(DEFAULT_URL).then(function (pdfDocument) { | |||
| defaultViewport: pdfPage.getViewport(SCALE), | |||
| // We can enable text/annotations layers, if needed | |||
| textLayerFactory: new PDFJS.DefaultTextLayerFactory(), | |||
| annotationsLayerFactory: new PDFJS.DefaultAnnotationsLayerFactory() | |||
| annotationsLayerFactory: new PDFJS.DefaultAnnotationLayerFactory() | |||
There was a problem hiding this comment.
The key needs to be changed here too, i.e., annotationsLayerFactory becomes annotationLayerFactory.
There was a problem hiding this comment.
Whoops, fixed now, thanks for noticing!
This patch makes the naming consistent with the `TextLayerBuilder`, and also the new `AnnotationLayer`, and should thus help reduce possible confusion when working with the code. Please note that the files were renamed using `git mv`, in order to preserve blame.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c12dbdfa6da488a/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c12dbdfa6da488a/output.txt Total script time: 0.78 mins Published |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/80649179c870d92/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/edf8fb638306750/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/edf8fb638306750/output.txt Total script time: 20.40 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/80649179c870d92/output.txt Total script time: 20.75 mins
|
…yerBuilder Remove a superfluous "s" in `AnnotationsLayerBuilder` from files in web/
|
Thank you for addressing this; it was bugging me too for some time. |
This patch makes the naming consistent with the
TextLayerBuilder, and also the newAnnotationLayer, and should thus help reduce possible confusion when working with the code.Please note that the files were renamed using
git mv, in order to preserve blame.