Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement annotation layer regression testing #6780

Merged

Conversation

timvandermeij
Copy link
Contributor

Fixes #6673.

page);
});
} else {
initPromise = Promise.resolve();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make annotationLayerCanvas = null; here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in the new commit.

@timvandermeij timvandermeij force-pushed the annotation-regression-tests branch 3 times, most recently from 7dee3c7 to 8a8e9b2 Compare December 18, 2015 23:48
@yurydelendik yurydelendik self-assigned this Dec 18, 2015
@timvandermeij timvandermeij force-pushed the annotation-regression-tests branch 2 times, most recently from 8aeeb07 to a4e1128 Compare December 19, 2015 00:18

var annotation_viewport = viewport.clone({ dontFlip: true });
PDFJS.AnnotationLayer.render(annotation_viewport, div, annotations,
page, new LinkServiceMock());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder: With PR #6770 landed, the parameters now need to be passed in as an object instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in the new commit.

@timvandermeij
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/dc3151ec85901e3/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/ca99b9e771221f2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/dc3151ec85901e3/output.txt

Total script time: 20.42 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/dc3151ec85901e3/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/ca99b9e771221f2/output.txt

Total script time: 20.60 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/ca99b9e771221f2/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/4915539bf39bf86/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/aab2683bb27f925/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/aab2683bb27f925/output.txt

Total script time: 20.38 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/aab2683bb27f925/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/4915539bf39bf86/output.txt

Total script time: 20.64 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/4915539bf39bf86/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor

Looks good. Thank you for the patch.

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/0100a7fcb9a0f9e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/4536234cc4c2591/output.txt

yurydelendik added a commit that referenced this pull request Dec 21, 2015
Implement annotation layer regression testing
@yurydelendik yurydelendik merged commit 9f23e11 into mozilla:master Dec 21, 2015
@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/0100a7fcb9a0f9e/output.txt

Total script time: 20.25 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/4536234cc4c2591/output.txt

Total script time: 20.41 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants