Ensure that hidden popups do not use any space #6807
Conversation
timvandermeij
force-pushed
the
popup-annotation-hidden
branch
from
dc06458
to
aaff5b8
Compare
| this.container = wrapper; | ||
| } | ||
| this.container.setAttribute('hidden', true); | ||
|
|
||
| var popup = this.popup = document.createElement('div'); |
There was a problem hiding this comment.
Nit: this.popup doesn't seem necessary any more.
There was a problem hiding this comment.
Done in the new commit.
|
It appears that the Edit: If possible, it would be really nice to have a test-case (with multiple annotations) to check that this works as intended. |
timvandermeij
force-pushed
the
popup-annotation-hidden
branch
from
aaff5b8
to
d388ada
Compare
|
The |
| this.color = parameters.color; | ||
| this.title = parameters.title; | ||
| this.contents = parameters.contents; | ||
| this.hideContainer = parameters.hideContainer; |
There was a problem hiding this comment.
Since the case of a Text annotation without an associated Popup annotation is special, it would seem a bit more logical if the the parameter was such that the caller explicitly had to set it to true, in order to get the special case (this.hideElement = wrapper; in the current code).
There was a problem hiding this comment.
Done in the new commit.
timvandermeij
force-pushed
the
popup-annotation-hidden
branch
from
d388ada
to
ae329af
Compare
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/3744a6b0183cb3c/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/3744a6b0183cb3c/output.txt Total script time: 0.82 mins Published |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/c6795e033d3693d/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/51b2d7fd0381bcc/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/c6795e033d3693d/output.txt Total script time: 20.44 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/51b2d7fd0381bcc/output.txt Total script time: 20.55 mins
|
|
Thanks for fixing this so quickly! |
Ensure that hidden popups do not use any space
Fixes #6806.