Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-minor] Add support for URLs in the document outline #6822

Merged
merged 1 commit into from Jan 19, 2016
Merged

[api-minor] Add support for URLs in the document outline #6822

merged 1 commit into from Jan 19, 2016

Conversation

Snuffleupagus
Copy link
Collaborator

Re: issue #5089.
(Note that since there are other outline features that we currently don't support, e.g. bold/italic text and custom colours, I thus think we can keep the referenced issue open.)

@Snuffleupagus
Copy link
Collaborator Author

Note that it isn't too common for PDF files to include URLs in the outline, but as the referenced issue demonstrates, it does happen in practice. Given that this patch validates the URL, only absolute ones are allowed, it shouldn't really be more unsafe than normal LinkAnnotations.

@timvandermeij Is this something that you'd be comfortable reviewing?

Re: issue 5089.
(Note that since there are other outline features that we currently don't support, e.g. bold/italic text and custom colours, I thus think we can keep the referenced issue open.)
@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/54d50ed63f09754/output.txt

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/fa0509af12896a1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/fbc2446aff3db0b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/fa0509af12896a1/output.txt

Total script time: 21.36 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/fbc2446aff3db0b/output.txt

Total script time: 21.45 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

timvandermeij added a commit that referenced this pull request Jan 19, 2016
[api-minor] Add support for URLs in the document outline
@timvandermeij timvandermeij merged commit 1eea0db into mozilla:master Jan 19, 2016
@timvandermeij
Copy link
Contributor

Thank you for fixing this!

@Snuffleupagus Snuffleupagus deleted the urls-in-outline branch January 19, 2016 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants