Improve work-around for importScripts bug. #6913
Conversation
|
Aw. requirejs's package.json is invalid (no version), so this PR does not work. We'll have to wait until the next version of RequireJS is released, and then update package.json to point to the new version instead of a specific hash. |
Rob--W
force-pushed
the
importScripts-work-around
branch
from
47bb01f
to
514d36c
Compare
|
I updated the PR, to include the patch directly in worker_loader.js instead of waiting for the next requirejs release. |
| @@ -15,6 +15,17 @@ | |||
|
|
|||
| 'use strict'; | |||
|
|
|||
| //#if !PRODUCTION | |||
| // Patch importScripts to work around a bug in WebKit and Chrome 48-. | |||
There was a problem hiding this comment.
add a space or second // here
Reverts "Hack to avoid intermidiate Chrome failures during tests." (2b2c521). require.js uses importScript asynchronously, which activates the worker GC bug in WebKit. This patch works around a bug in a way that is similar in the upcoming (but not yet released) require.js 2.1.23 The advantage of the new work-around is that it allows the runtime to garbage-collect idle Workers. References: - https://crbug.com/572225 - https://webkit.org/b/153317
Rob--W
force-pushed
the
importScripts-work-around
branch
from
514d36c
to
097e273
Compare
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/e4abe24a3a6a4d5/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/e4abe24a3a6a4d5/output.txt Total script time: 0.82 mins Published |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/68ff34a546de900/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/b866eacbde60aa7/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/b866eacbde60aa7/output.txt Total script time: 20.26 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/68ff34a546de900/output.txt Total script time: 21.69 mins
|
|
Landing with r=me and r=yurydelendik (see http://logs.glob.uno/?c=mozilla%23pdfjs&s=3+Feb+2016&e=3+Feb+2016#c46063). Thank you for the patch! |
Improve work-around for importScripts bug.
Reverts "Hack to avoid intermidiate Chrome failures during tests." (2b2c521).
Updates require.js to the latest version (pre-release), which includes an alternative work-around for the bug that was worked around by the reverted commit. The advantage of the new work-around is that it allows the runtime to garbage-collect idle Workers.
References:
Addresses #6877