Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor lookup hash tables/objects #6915

Merged
merged 7 commits into from
Jan 28, 2016

Conversation

yurydelendik
Copy link
Contributor

Fixes #6774 (by adding lazy initialization to the large lookup tables).

Mostly refactors fonts.js file by moving large tables to separate files. Also replaces literal {} usages for cache and lookup tables.

@yurydelendik
Copy link
Contributor Author

TODO:

  • remove all hasOwnProperty

@yurydelendik
Copy link
Contributor Author

not all hasOwnProperty we can remove atm (one in canvas.js shall be refactored to use instanceof instead)

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/6e9bf13ac6311ec/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/66701d2df93b6fd/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/66701d2df93b6fd/output.txt

Total script time: 21.23 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/6e9bf13ac6311ec/output.txt

Total script time: 21.83 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor Author

intialization arrays are replaced by js code

/botio test

@brendandahl
Copy link
Contributor

r+ pending test runs

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/87c78b02446ac72/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/876939fdf6ee02f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/87c78b02446ac72/output.txt

Total script time: 19.98 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/876939fdf6ee02f/output.txt

Total script time: 21.46 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor Author

/botio-windows preview

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/b32d786bec11138/output.txt

yurydelendik added a commit that referenced this pull request Jan 28, 2016
Refactor lookup hash tables/objects
@yurydelendik yurydelendik merged commit 825a222 into mozilla:master Jan 28, 2016
@yurydelendik yurydelendik deleted the lookuptables branch January 28, 2016 21:02
@yurydelendik
Copy link
Contributor Author

(makes #6777 easier -- some dependencies where moved from font.js)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants