Ensure that we don't modify the Dict data when the Differences array of a font contains indirect objects
#6940
Conversation
…ray of a font contains indirect objects This patch fixes an issue that I inadvertently introduced in PR 5815, where we accidentally modify the `Differences` array in the encoding dictionary for indirect objects. Instead of this change, we could also have used the now existing `Dict_getArray`. However in this case I don't think that would have been a good idea, since it would mean iterating through the array *twice*.
|
It appears that Firefox on Linux now fails consistently after |
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/f33b2902a217abf/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/f33b2902a217abf/output.txt Total script time: 0.82 mins Published |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/2a533e531504241/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/78ddae238b14376/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/2a533e531504241/output.txt Total script time: 19.97 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/78ddae238b14376/output.txt Total script time: 21.49 mins
|
|
The bot is fine again, but I have opened #6944 to track the failures we see lately. |
…objects Ensure that we don't modify the `Dict` data when the `Differences` array of a font contains indirect objects
|
Thank you! |
This patch fixes an issue that I inadvertently introduced in PR #5815, where we accidentally modify the
Differencesarray in the encoding dictionary for indirect objects.Instead of this change, we could also have used the now existing
Dict_getArray. However in this case I don't think that would have been a good idea, since it would mean iterating through the array twice.