Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the PDFJS.postMessageTransfer parameter to the worker, so that the MessageHandler can be setup correctly in createDocumentHandler (issue 6957) #7088

Merged
merged 1 commit into from
Mar 18, 2016

Conversation

Snuffleupagus
Copy link
Collaborator

This regressed in commit acdd49f, i.e. PR #6571.

Fixes #6957.

… the `MessageHandler` can be setup correctly in `createDocumentHandler` (issue 6957)

This regressed in commit acdd49f, i.e. PR 6571.

Fixes 6957.
@brendandahl
Copy link
Contributor

My machine with ie10 is having issues. Can anyone else verify? @timvandermeij

@jslatts
Copy link

jslatts commented Mar 17, 2016

I can confirm that this fixes the issue for IE10 on Windows 8.

@timvandermeij
Copy link
Contributor

@brendandahl I only use Arch Linux now and no longer use Windows (and have no VM for it), so unfortunately I cannot test this. However, given that @jslatts confirmed that this fixes the issue and the patch makes sense, I think we can be relatively sure that this works.

@brendandahl
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/3ec53685f17562b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/42c6bf6def3a0b8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/3ec53685f17562b/output.txt

Total script time: 20.08 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/42c6bf6def3a0b8/output.txt

Total script time: 22.15 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

brendandahl added a commit that referenced this pull request Mar 18, 2016
Pass the `PDFJS.postMessageTransfer` parameter to the worker, so that the `MessageHandler` can be setup correctly in `createDocumentHandler` (issue 6957)
@brendandahl brendandahl merged commit 56f5c3a into mozilla:master Mar 18, 2016
@Snuffleupagus Snuffleupagus deleted the issue-6957 branch March 18, 2016 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants