Prevents document zooming if still scrolling and meta keys pressed (Issue #7022) #7097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManasJayanth
changed the title
| @@ -1873,12 +1873,12 @@ window.addEventListener('pagechange', function pagechange(evt) { | |||
| } | |||
| }, true); | |||
|
|
|||
| var zoomDisabled = false, zoomDisablerId; | |||
There was a problem hiding this comment.
Nit: zoomDisablerId seems to me like a slightly strange name, how about zoomDisabledTimeout instead?
|
This PR needs a rebase after recently landed PRs. Furthermore, please change the commit message to be equal to the PR message, since the latter is much more descriptive. |
keys active at the outset, for 1000ms
|
@timvandermeij Done! Ready for review |
|
Works nicely, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables zooming when the stream of events that don't have meta/ctrl
keys active at the outset, for 100ms
[UPDATE] 1000ms