Ensure that TrueType font tables have uint32 checksums
#7098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to "The table directory" under https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6.html#Directory, TrueType font tables should have `uint32` checksums. This is something that I noticed, and was initially confused about, while debugging a TrueType issue. As far as I can tell, the current (`int32`) checksums we use doesn't cause any issues in practice. However, I do think that this should be addressed to agree with the specification, and to reduce possible confusion when reading the font code.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/d1cdf6db063bf57/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/a604899a4087bdb/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/a604899a4087bdb/output.txt Total script time: 20.26 mins
|
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/d1cdf6db063bf57/output.txt Total script time: 24.01 mins
Image differences available at: http://107.21.233.14:8877/d1cdf6db063bf57/reftest-analyzer.html#web=eq.log |
yurydelendik
added a commit
that referenced
this pull request
Mar 22, 2016
Ensure that TrueType font tables have `uint32` checksums
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to "The table directory" under https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6.html#Directory, TrueType font tables should have
uint32checksums.This is something that I noticed, and was initially confused about, while debugging a TrueType issue.
As far as I can tell, the current (
int32) checksums we use doesn't cause any issues in practice. However, I do think that this should be addressed to agree with the specification, and to reduce possible confusion when reading the font code.