Keep track of the character to glyph mapping in font_renderer.js, to prevent errors when different characters point to the same glyph (issue 7101) #7106
Conversation
Snuffleupagus
added
font-conversion
4-work-in-progress
and removed
4-work-in-progress
labels
| @@ -656,7 +669,8 @@ var FontRendererFactory = (function FontRendererFactoryClosure() { | |||
| this.glyphs = glyphs; | |||
| this.cmap = cmap; | |||
|
|
|||
| this.compiledGlyphs = []; | |||
| this.compiledGlyphs = Object.create(null); | |||
| this.compiledCharCodeToGlyphId = Object.create(null); | |||
There was a problem hiding this comment.
Looking through this once more, I'm assuming that these two lines could actually be removed given the CompiledFont.call(this, fontMatrix); line above?
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/c0ca6065a2d6ec0/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/c0ca6065a2d6ec0/output.txt Total script time: 1.59 mins Published |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/a745235285f9013/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/584893c23c1017c/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/584893c23c1017c/output.txt Total script time: 20.39 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/a745235285f9013/output.txt Total script time: 22.08 mins
|
…prevent errors when different characters point to the same glyph (issue 7101) Fixes 7101.
|
Updated to fix a merge conflict in |
|
Looks good. Thank you for the patch. /botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/2d18ddc2766507d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/0abcafa947dd73b/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/0abcafa947dd73b/output.txt Total script time: 20.13 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/2d18ddc2766507d/output.txt Total script time: 21.39 mins
|
I've not yet had time to create a reduced test-case, and I'm not sure if we'll be able to test this using only an appropriate text rendering mode (i.e.4-7), or ifdisableFontFace = trueis actually necessary.Fixes #7101.