[Bug 1237908] Make pdf.js use the correct principal origin attributes when loading … #7114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // e.g. useful for NoScript | ||
| var ssm = Cc['@mozilla.org/scriptsecuritymanager;1'] | ||
| .getService(Ci.nsIScriptSecurityManager); | ||
| var uri = NetUtil.newURI(PDF_VIEWER_WEB_PAGE, null, null); | ||
| var resourcePrincipal; | ||
| //#if MOZCENTRAL | ||
| resourcePrincipal = ssm.createCodebasePrincipal(uri, {}); | ||
| resourcePrincipal = ssm.createCodebasePrincipal(uri, aRequest.loadInfo.originAttributes); |
There was a problem hiding this comment.
Lint complains about this line being too long.
There was a problem hiding this comment.
Should this change also be made at line 1104 just below?
|
You're right, let me fix these two things. Thanks for the feedback. |
|
After fixing this, please make sure that the commits are squashed (https://github.com/mozilla/pdf.js/wiki/Squashing-Commits). |
|
@timvandermeij I fixed the patch and squashed everything to a single commit. Thanks for the review feedback. |
yurydelendik
changed the title
|
Thank you for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…subresources.