Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors to remove stream.js dependency on colorspace.js #7134

Merged
merged 1 commit into from
Apr 1, 2016

Conversation

yurydelendik
Copy link
Contributor

Partially addresses #6777

Shall we use isNativelySupported instead of isNativelyDecodable ?

@Snuffleupagus
Copy link
Collaborator

The title/commit message says "Refactors to remove image.js dependency on colorspace.js", but shouldn't this rather be "Refactors to remove stream.js dependency on colorspace.js", given the code changes (there's still a Image/ColorSpace dependency left)?

Note that @brendandahl suggested a slight name change, see http://logs.glob.uno/?c=mozilla%23pdfjs&s=31+Mar+2016&e=31+Mar+2016#c48005. I don't have a strong opinion either way, so change this if you see fit.

r=me, with the above addressed, and passing tests.

@yurydelendik yurydelendik changed the title Refactors to remove image.js dependency on colorspace.js Refactors to remove stream.js dependency on colorspace.js Apr 1, 2016
@yurydelendik
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2016

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/30be6a76fd935f1/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2016

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/4bbcee57efe086a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2016

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/30be6a76fd935f1/output.txt

Total script time: 20.19 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2016

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/4bbcee57efe086a/output.txt

Total script time: 21.78 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik yurydelendik merged commit a250c15 into mozilla:master Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants