Use beforeAll/afterAll in CipherTransformFactory in crypto_spec.js (issue 6905)
#7174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….js (issue 6905 This patch also adds/improves utility functions for checking if the passwords are correct/incorrect, and replaces `string2binary` with `stringToBytes`. Finally the patch does away with the `DictMock`, in favour of using actual `Dict`s. Re: issue 6905.
Snuffleupagus
changed the title
beforeAll in CipherTransformFactory in crypto_spec.js (issue 6905)beforeAll/afterAll in CipherTransformFactory in crypto_spec.js (issue 6905)
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/6d84b00796ebc67/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/a0e89809869376e/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/a0e89809869376e/output.txt Total script time: 1.50 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/6d84b00796ebc67/output.txt Total script time: 1.72 mins
|
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch also adds/improves utility functions for checking if the passwords are correct/incorrect, and replaces
string2binarywithstringToBytes. Finally the patch does away with theDictMock, in favour of using actualDicts.Re: issue #6905.
_Note:_ Perhaps marginally easier reviewing with https://github.com/mozilla/pdf.js/compare/master...Snuffleupagus:issue-6905-crypto_spec?w=1.