Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes hijack describe() hack from unit tests. #7178

Merged
merged 1 commit into from
Apr 11, 2016

Conversation

yurydelendik
Copy link
Contributor

Continuation of #6905. We don't need hack that replaces Jasmine's describe method and then restores it when PDFJS is loaded.

@yurydelendik
Copy link
Contributor Author

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_unittest from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/57679970be6bc8a/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/446c768b762a1a2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/57679970be6bc8a/output.txt

Total script time: 1.54 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/446c768b762a1a2/output.txt

Total script time: 1.66 mins

  • Unit Tests: Passed

@yurydelendik
Copy link
Contributor Author

URL constructor is not support by IE (see https://developer.mozilla.org/en-US/docs/Web/API/URL/URL). Ignoring this since we don't run tests with web/compatibility,js anyway. Trivial

@yurydelendik yurydelendik merged commit b282885 into mozilla:master Apr 11, 2016
@yurydelendik yurydelendik deleted the rm-describe-test-hack branch April 11, 2016 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants