Moves all document.getElementById lookups into viewer.js #7209
Conversation
yurydelendik
force-pushed
the
getElementById
branch
from
f7b772a
to
931a12b
Compare
| lessInfoButton: document.getElementById('errorShowLess'), | ||
| }, | ||
| printContainer: document.getElementById('printContainer'), | ||
| openFileInputName: 'fileInput', |
There was a problem hiding this comment.
I think it would be more consistent to use document.getElementById('fileInput') for this line too. The advantage is that we then do not have to query for the input in other places anymore (such as the secondary toolbar), but we can directly use this element. Let's call it openFileInput in this case.
There was a problem hiding this comment.
The fileInput is dynamically created only for non-extension/demo viewer. I would rather change the code later to generate dynamic name for it (but there is some dependency on app in secondary toolbar we need to resolve first)
There was a problem hiding this comment.
(btw, it's okay to have non-HTML elements in this configuration, I just pulled DOM elements here)
There was a problem hiding this comment.
I see. In that case let's forget about my comment for now.
yurydelendik
force-pushed
the
getElementById
branch
from
931a12b
to
d12d308
Compare
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/eaddb8a494fdc2f/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/eaddb8a494fdc2f/output.txt Total script time: 1.00 mins Published |
yurydelendik
force-pushed
the
getElementById
branch
from
d12d308
to
7f89de1
Compare
yurydelendik
force-pushed
the
getElementById
branch
from
7f89de1
to
b6c74f2
Compare
|
Looks good, thank you! |
This shall make the generic viewer customization easier.