Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the two paths in PDFImage.resize into separate helper functions, placed in colorspace.js and image.js #7210

Merged
merged 1 commit into from
Apr 17, 2016
Merged

Conversation

Snuffleupagus
Copy link
Collaborator

Re: issue #6777.

@yurydelendik I've taken a stab at implementing what you suggested on IRC yesterday. Is this approximately what you had in mind?

@yurydelendik
Copy link
Contributor

yurydelendik commented Apr 17, 2016

Yes, this looks right. Please notice that dest is present for resizeRgbImage and not present for resizeImageMask -- this can be optimized too. (Remove also COMPONENTS from resizeImageMask)

Looks good with the changes above and tests pass. Thank you.

…ns, placed in colorspace.js and image.js

Re: issue 6777.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/106eb605fa52251/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/7f482ba6a2cab6b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/7f482ba6a2cab6b/output.txt

Total script time: 20.32 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/106eb605fa52251/output.txt

Total script time: 22.46 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor

"+74 −79" even with comments 👍

Thank you for the patch.

@yurydelendik yurydelendik merged commit 3228c94 into mozilla:master Apr 17, 2016
@Snuffleupagus Snuffleupagus deleted the extract-PDFImage.resize branch April 17, 2016 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants