Convert the password prompt to a class #7219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| this.passwordCancel.addEventListener('click', this.close.bind(this)); | ||
| this.callback = null; |
There was a problem hiding this comment.
Hmm, callback seems a bit too generic to me. I think that the reason for the current code using updatePassword is that it's called that in the API (see https://github.com/mozilla/pdf.js/blob/master/src/display/api.js#L1361). How about e.g. updateCallback instead?
There was a problem hiding this comment.
You're right. I have changed this to updateCallback in the new commit.
timvandermeij
force-pushed
the
password-prompt-class
branch
from
7b936cd
to
70de173
Compare
Furthermore we introduce two new methods named `setCallback` and `setReason` so external code does not change the properties of the class directly. Finally we update various names of properties and methods to be more self-explanatory.
timvandermeij
force-pushed
the
password-prompt-class
branch
from
70de173
to
2b7137b
Compare
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/2c7d5b62cbbb363/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/2c7d5b62cbbb363/output.txt Total script time: 1.01 mins Published |
|
Thank you for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Furthermore we introduce a new method named
setUpdateCallbackso external code does not change the properties of the class directly. We also update various names of properties and methods to be more self-explanatory.Use, for example, http://async5.org/moz/passwordOU.pdf to verify this patch.