Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves all testing into gulpfile. #7260

Merged
merged 1 commit into from May 2, 2016

Conversation

yurydelendik
Copy link
Contributor

No description provided.

@timvandermeij
Copy link
Contributor

There appears to be an issue on the Windows bot with this patch regarding output buffering. The lint command fails directly without even trying and the unittest/test commands show no output in the logs until everything is done. Any idea what is causing this?

@yurydelendik
Copy link
Contributor Author

yurydelendik commented Apr 30, 2016

Any idea what is causing this?

I'm thinking we had this issue before. Trying to fix.

@yurydelendik
Copy link
Contributor Author

installing newer node.js on botio fixed the issue

@@ -18,16 +18,19 @@
'use strict';

var fs = require('fs');
var path = require('path');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable appears to be unused, so we should be able to remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@timvandermeij
Copy link
Contributor

/botio lint

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2016

From: Bot.io (Linux)


Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/ad2db1cab51da04/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2016

From: Bot.io (Windows)


Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/cce63fab52ccfcf/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2016

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/ad2db1cab51da04/output.txt

Total script time: 1.18 mins

  • Lint: Passed

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2016

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/cce63fab52ccfcf/output.txt

Total script time: 2.04 mins

  • Lint: Passed

@timvandermeij
Copy link
Contributor

/botio unittest

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2016

From: Bot.io (Linux)


Received

Command cmd_unittest from @timvandermeij received. Current queue size: 1

Live output at: http://107.21.233.14:8877/fe96086ec3ca0d0/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2016

From: Bot.io (Windows)


Received

Command cmd_unittest from @timvandermeij received. Current queue size: 1

Live output at: http://107.22.172.223:8877/cf40dbebe6a3f7b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2016

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/fe96086ec3ca0d0/output.txt

Total script time: 1.74 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2016

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/cf40dbebe6a3f7b/output.txt

Total script time: 1.77 mins

  • Unit Tests: Passed

@timvandermeij
Copy link
Contributor

/botio preview

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2016

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/15759cda0b975bf/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2016

From: Bot.io (Windows)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/95ed8435076f3c8/output.txt

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2016

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/782762232bfaaf6/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2016

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/8ffe8d0a68f7b0b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2016

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/782762232bfaaf6/output.txt

Total script time: 21.47 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2016

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/8ffe8d0a68f7b0b/output.txt

Total script time: 27.38 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit d179992 into mozilla:master May 2, 2016
@timvandermeij
Copy link
Contributor

Nice work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants