check WeChat #7822
Closed
check WeChat #7822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solve issue: mozilla#7815 mozilla#7754 mozilla#7800
Snuffleupagus
requested changes
Nov 16, 2016
There was a problem hiding this comment.
When you've addressed the two inline comments, don't forget to squash the commits (see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits).
Edit: Also, the commit message could probably be improved, since "check WeChat" isn't terribly informative. How about e.g. "Disable range requests in compatibility.js for the WeChat browser" instead?
| @@ -469,8 +469,10 @@ if (typeof PDFJS === 'undefined') { | |||
|
|
|||
| // Range requests are broken in Chrome 39 and 40, https://crbug.com/442318 | |||
| var isChromeWithRangeBug = /Chrome\/(39|40)\./.test(navigator.userAgent); | |||
|
|
|||
There was a problem hiding this comment.
Please remove the two trailing spaces from this line.
| @@ -469,8 +469,10 @@ if (typeof PDFJS === 'undefined') { | |||
|
|
|||
| // Range requests are broken in Chrome 39 and 40, https://crbug.com/442318 | |||
| var isChromeWithRangeBug = /Chrome\/(39|40)\./.test(navigator.userAgent); | |||
|
|
|||
| var isWeChat = /micromessenger/.test(navigator.userAgent); | |||
There was a problem hiding this comment.
It's probably best to make this regular expression case-insensitive, to prevent any future issues, e.g. change it to /micromessenger/i.test(navigator.userAgent); instead.
|
Superseded by #7841. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve issue:
#7815
#7754
#7800