Check for undefined #8640
Merged
Check for undefined #8640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new URL(file, window.location.href) throws the following error in IE11 + iPad Safari: Unable to get property 'replace' of undefined or null reference
Added curly braces
brendandahl
suggested changes
Jul 12, 2017
web/app.js
Outdated
| @@ -1404,6 +1404,9 @@ if (typeof PDFJSDev === 'undefined' || PDFJSDev.test('GENERIC')) { | |||
| 'http://mozilla.github.io', 'https://mozilla.github.io']; | |||
| validateFileURL = function validateFileURL(file) { | |||
| try { | |||
| if (file === undefined) { | |||
There was a problem hiding this comment.
Let's move this up out of the try/catch.
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
* Check for undefined new URL(file, window.location.href) throws the following error in IE11 + iPad Safari: Unable to get property 'replace' of undefined or null reference * Adapting previous change to pdf.js code standards Added curly braces * Moved check for undefined above try/catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new URL(file, window.location.href)throws the following error in IE11 + iPad Safari whenfileis undefined:Unable to get property 'replace' of undefined or null reference