Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fallback for non-embedded SegoeUISymbol font (issue 8697) #8698

Merged
merged 1 commit into from Jul 25, 2017
Merged

Add a fallback for non-embedded SegoeUISymbol font (issue 8697) #8698

merged 1 commit into from Jul 25, 2017

Conversation

Snuffleupagus
Copy link
Collaborator

The PDF file uses a non-embedded SegoeUISymbol font, which is not a standard font (and is mainly used by Microsoft, see https://en.wikipedia.org/wiki/Segoe).

Fixes #8697.

The PDF file uses a non-embedded SegoeUISymbol font, which is *not* a standard font (and is mainly used by Microsoft, see https://en.wikipedia.org/wiki/Segoe).

Fixes 8697.
@mozilla mozilla deleted a comment from pdfjsbot Jul 25, 2017
@mozilla mozilla deleted a comment from pdfjsbot Jul 25, 2017
@mozilla mozilla deleted a comment from pdfjsbot Jul 25, 2017
@mozilla mozilla deleted a comment from pdfjsbot Jul 25, 2017
@mozilla mozilla deleted a comment from pdfjsbot Jul 25, 2017
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/cbc83d893a31905/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.215.176.217:8877/dd06950d0dfe04f/output.txt

@mozilla mozilla deleted a comment from pdfjsbot Jul 25, 2017
@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/cbc83d893a31905/output.txt

Total script time: 16.63 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/dd06950d0dfe04f/output.txt

Total script time: 29.12 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

Copy link
Contributor

@yurydelendik yurydelendik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch.

@timvandermeij
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/c5c8625d2a7b9c6/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/94b5d19b109018d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/c5c8625d2a7b9c6/output.txt

Total script time: 15.51 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/94b5d19b109018d/output.txt

Total script time: 27.41 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@timvandermeij timvandermeij merged commit 37ac8f8 into mozilla:master Jul 25, 2017
@timvandermeij
Copy link
Contributor

Thank you!

@Snuffleupagus Snuffleupagus deleted the issue-8697 branch July 25, 2017 21:07
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
Add a fallback for non-embedded SegoeUISymbol font (issue 8697)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants