[api-minor] Fix various issues related to pageSize, and display the size for the active page in the document properties dialog #9577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `getPageSizeInches` method was implemented on `PDFDocumentProxy`, which seems conceptually wrong since the size property isn't global to the document but rather specific to each page. Hence the method is moved into `PDFPageProxy`, as `get pageSizeInches` instead to address this. Despite the fact that new API functionality was implemented, no unit-tests were added. To prevent issues later on, we should *always* ensure that new functionality has at least some test-coverage; something that this patch also takes care of. The new `PDFDocumentProperties._parsePageSize` method seemed unnecessary convoluted. Furthermore, in the "no data provided"-case it even returned incorrect data (an array, rather than the expected object). Finally, the fallback strings didn't actually agree with the `en-US` locale. This inconsistency doesn't look too great, and it's thus addressed here as well.
The units are currently repeated after each dimension, which seems unnecessary and is also not done in other PDF viewers (such as e.g. Adobe Reader). Furthermore, the name of the l10n arguments can be simplified slightly, since the name of the strings themselves should be enough information. Finally, the `width`/`height` should be formatted according to the current locale, as is already done for other strings in the document properties dialog.
…ialog, when it's already been correctly set
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/bbcc801b678897f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/bbcc801b678897f/output.txt Total script time: 2.79 mins Published |
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a9260d8ca4e857a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/7c685629a1afbd6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/a9260d8ca4e857a/output.txt Total script time: 2.95 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/7c685629a1afbd6/output.txt Total script time: 6.82 mins
|
timvandermeij
approved these changes
Mar 18, 2018
|
Awesome; thank you for fixing this! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
[api-minor] Fix various issues related to pageSize, and display the size for the active page in the document properties dialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glancing quickly at the recent implementation of pageSize, for the document properties dialog, there were a couple of things that seemed to benefit from some refactoring; please see the commit messages for details.
Edit: Can be tested with e.g. https://github.com/mozilla/pdf.js/blob/master/test/pdfs/sizes.pdf.