Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

etag of sign_in does not correctly update in all circumstances #1331

Closed
shane-tomlinson opened this issue Mar 22, 2012 · 3 comments
Closed

Comments

@shane-tomlinson
Copy link

Link to issue #403

On Stage, the etags of /sign_in only gets updated if dialog.ejs is updated. If only dialog_layout.ejs or only the included JS are updated, the etags are not updated meaning the old content will be delivered to the user.

lloyd added a commit that referenced this issue Mar 23, 2012
…otfix for issue #1331 - will be fixed properly in dev.
@jbonacci
Copy link
Contributor

Verified as fixed in Stage after the Hot Fix was pushed...

@lloyd
Copy link
Contributor

lloyd commented Mar 27, 2012

re-opening this issue, because it is not yet fixed in dev, 5 star label still appropriate because it would block the wed. train from getting cut (@jbonacci - for reference, we hotfixed with a minimal patch, then rounded back in dev and are trying to do the right thing in pull request #1338)

@ozten will close this at PR merge time into dev, provided he doesn't find any more gaping holes in my fix :)

ozten added a commit that referenced this issue Mar 27, 2012
use etagify for content-based hashes in ETag headers - issue #1331
@lloyd lloyd closed this as completed Mar 27, 2012
@jbonacci
Copy link
Contributor

jbonacci commented Apr 7, 2012

Verified fixes for Dev in code...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants