Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

network.cookiesEnabled can call its onComplete callback twice #1339

Closed
shane-tomlinson opened this issue Mar 27, 2012 · 1 comment
Closed

network.cookiesEnabled can call its onComplete callback twice #1339

shane-tomlinson opened this issue Mar 27, 2012 · 1 comment
Assignees
@shane-tomlinson
Labels
qa:verified ★★★★

Comments

@shane-tomlinson
Copy link

If the browser's cookies are enabled but the onComplete callback to network.cookiesEnabled throws an exception, onComplete will be called a second time with a false status, leading developers (or users) to falsely believe that cookies are disabled.

Steps to reproduce:
See #1323
@ghost ghost assigned shane-tomlinson Mar 27, 2012
@shane-tomlinson shane-tomlinson mentioned this issue Mar 27, 2012
Closed
shane-tomlinson pushed a commit that referenced this issue Mar 27, 2012
Fix cookiesEnabled being possible to call it's onComplete callback tw…
b3cbaa0 
…ice if onComplete throws an exception the first time.

issue #1339
@shane-tomlinson shane-tomlinson mentioned this issue Mar 27, 2012
Merged
@lloyd lloyd closed this as completed in d355791 Mar 27, 2012
@jbonacci
Copy link
Contributor

jbonacci commented Apr 7, 2012

Verified in code and through unit tests on Dev.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shane-tomlinson shane-tomlinson

Labels
qa:verified ★★★★
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lloyd @shane-tomlinson @jbonacci