Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

implement final property names in API #1643

Closed
lloyd opened this issue May 24, 2012 · 2 comments
Closed

implement final property names in API #1643

lloyd opened this issue May 24, 2012 · 2 comments

Comments

@lloyd
Copy link
Contributor

lloyd commented May 24, 2012

on list we've agreed:

privacyURL -> privacyPolicy

and

tosURL -> termsOfService

This is the final planned change to the new Observer API which becomes "stable" this train...

lloyd added a commit that referenced this issue May 24, 2012
support final property names in .request() API - issue #1643
@jrgm
Copy link
Contributor

jrgm commented May 27, 2012

This was for PR in GH-1644 and was merged and in train-2012.05.25. Closing this issue. On the Changlog list to verify this train.

@jrgm jrgm closed this as completed May 27, 2012
@jrgm
Copy link
Contributor

jrgm commented May 29, 2012

Verified for stage train-2012.05.25. If both the deprecated 'privacyURL' and 'tosURL' are passed, links to those URL are shown in the dialog. If the new 'privacyPolicy' and 'termsOfService' are passed in, those URLs are shown. If all four are passed in, the deprecated form wins (i.e., the value of privacyURL is preferred to privacyPolicy). Small issue that I'll just put in separately (and wontfix-because-x is fine with me). Also this doc needs updating to the new params https://developer.mozilla.org/en/DOM/navigator.id.get

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants