Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

rework popup identification in bidpom #2429

Closed
klrmn opened this issue Sep 5, 2012 · 2 comments
Closed

rework popup identification in bidpom #2429

klrmn opened this issue Sep 5, 2012 · 2 comments
Labels
qa:verified

Comments

@klrmn
Copy link
Contributor

klrmn commented Sep 5, 2012

from @davehunt via email:

BIDPOM currently cycles through the open windows until it finds out with the appropriate page title. This is a little more fragile than I'd like as the page title should be able to change without affecting the tests (and the page title is different in each locale). Since #1023 has been fixed we can improve BIDPOM by referencing the popup window by name "__persona_dialog". Leah: this would certainly be a worthwhile enhancement if you'd like to take it.
@klrmn
Copy link
Contributor Author

klrmn commented Sep 6, 2012

#2434

@klrmn klrmn closed this as completed Sep 6, 2012
@jaredhirsch
Copy link
Member

@klrmn: thanks for filing the bug and the pull request to fix it!

Just a procedural note - to keep issues up to date, I'll close tickets right when I merge in pull requests.

jaredhirsch added a commit that referenced this issue Sep 6, 2012
@jaredhirsch
Merge pull request #2434 from klrmn/issue_2429_rework_popup_identific…
42b42e2 
…ation

Use popup title to identify popup window in selenium page objects. Fixes #2429.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
qa:verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaredhirsch @klrmn