A message should be displayed for unsupported browsers #273
Comments
Shane - did you determine this with a specific browser on a specific platform? |
@jbonacci: our minimum technical requirements are window.localStorage and window.postMessage. Even with these requirements met, there are performance issues to worry about - for instance iOS takes ~20 seconds per key generated, IE8 about the same. The other hitch that seems to be getting us right now is whether we can communicate between windows, this is especially problematic on mobile browsers. |
So, then, maybe we do need to document this as well as show some dialog. |
a8230cc displays an alert and will not open the dialog. We could use a cleaner solution, perhaps a nice page? |
labeled 'needs UX input' |
OK, instead of a dialog I want to use the center space for our error messages. The important thing here is to decide what we want our users to be able to do. We can say "IE doesn't work" but we should explain why and what they could do to actually sign in, like use Firefox. It would be great to have a breakdown of the various browser support situations on a wiki page that we can link to. I think as a minimal approach, starting from the basics of what I have, I want to say "This isn't supported but modern browsers like Firefox are. Check out our full support page here for other options." Something more like this: http://cl.ly/3Y311l0g421k0A0A2T1G however possibly less Firefox branding. |
I like this idea. I have been (gently) pushing for a public doc site, so maybe a support site would be a nice companion to that. |
@clarkbw, we need a solution that addresses other browsers that are incompatible as well, right now we check for Internet Explorer <= 8 and display an IE specific message. We also check for browsers that do not support localStorage, postMessage, and if the browser has problems with JSON.decode(null) (Android < 3.0) and display a generic message. This brings up a question of whether we should have an API method that an RP can call to see if the user's browser supports BrowserID. If the browser does not support BrowserID, they could avoid displaying the button? |
@clarkbw - your response from our email - "Agreed, I'm wondering if we want to do a bit of both. For mobile browsers we have a bit of different layout and I think we'll want to continue that in this kind of error page. I'd suggest we file a separate bug for the query API. " I'll tackle this as you suggest with http://cl.ly/3Y311l0g421k0A0A2T1G. We'll get an initial rev and then iterate. |
Adding a controller, tests, adding browser-support.js and tests. issue #273
Baaahh! I had this entirely within the dialog and then realized that the approach will not work for browsers that do not have window.postMessage. The reason is we wait until the channel is set up to redirect to the normal dialog site. Since window.postMessage does not exist, the redirect never happens. Going to change tack, going to do the checking from include.js. If the check fails, I am going to redirect to an alternate page to display in the dialog. |
Adding a controller, tests, adding browser-support.js and tests. issue #273
Adding unsupported_dialog as a path. Making both signin and unsupported ailog use dialog_layout as its layout. Adding unit tests to make sure the front facing pages we expect are actually there. issue #273
* IE specific message from unsupported_dialog.ejs * reason (which went to unsupported_dialog) from app.js * last bits of checkSupport from dialog_controller.js issue #273
…de, @stomlinson, that firefox logo is pretty overwhelming) - issue #273
Not the easiest thing to test since I usually keep my browser updates fresh, even on VMs. Error message verified: We're sorry, but currently your browser isn't supported. The "learn more" link correctly opens diresworb.org The "modern browsers" link goes to http://whatbrowser.org/. Here is my issue with going to this site: Do we really want to use this link if Firefox is not prominently displayed on the page? |
If we check for window.localStorage and window.postMessage, we should be able to find a large portion of browsers that are not supported.
The text was updated successfully, but these errors were encountered: