This repository has been archived by the owner on May 10, 2019. It is now read-only.
Fix the link color of the cancel button in the required email check email screen. #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mail screen. * A little bit of cleanup to simplify the check_registration controller - there is only a back button now. * In the ejs template, remove the href and id attributes from the strings passed to localizers. Always use back for the id. * Add a test to make sure the correct messages are triggered whenever pressing the back button. issue #1453
|
was it your intention that upon click of the 'cancel' link the dialog would close? |
lloyd
added a commit
that referenced
this pull request
Apr 19, 2012
…l_confirm_link Fix the link color of the cancel button in the required email check email screen.
|
@lloyd - yes, closing the dialog is the desired behavior. In the required email case, if the user selects "cancel" after they have sent the email, they have no state to which they can return to and take an alternative path. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #1453