This repository has been archived by the owner on May 10, 2019. It is now read-only.
Getting a bunch of new KPIs ready #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -97,6 +107,10 @@ BrowserID.State = (function() { | |||
| handleState("new_user", function(msg, info) { | |||
| self.newUserEmail = info.email; | |||
|
|
|||
| // Add new_account to the KPIs *before* the staging occurs allows us to | |||
| // know when we are losing users due to the email verification. | |||
| mediator.publish("kpi_data", { new_account: true }); | |||
There was a problem hiding this comment.
Nice. Yes, we have to publish data pretty early so we don't have nay blind spots. Good call.
|
Just one question before r+... Otherwise, Code looks great. I didn't run locally. I can't find test output on Travis CI. |
| @@ -95,7 +95,12 @@ | |||
| timestamp: now, | |||
| local_timestamp: now, | |||
| lang: "bar", | |||
| secret: "Attack at dawn!!!" | |||
|
afaict we need one more commit on this PR to address the "new var 'current' instead of 'controller.getCurrent()' here". I'll re-read, but I can't see any other major issues. I'll add a patch, test and merge in about 2 hrs if there's no response before then. |
|
with the last patch, r+ - checking tests and merging.. |
lloyd
added a commit
that referenced
this pull request
Jun 26, 2012
Getting a bunch of new KPIs ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #1667
issue #1730