Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

Add a console message if only one of privacyPolicy or termsOfService is defined. #2202

Merged
merged 2 commits into from
Aug 10, 2012
Merged

Add a console message if only one of privacyPolicy or termsOfService is defined. #2202

merged 2 commits into from
Aug 10, 2012

Conversation

shane-tomlinson
Copy link

issue #1438

@ghost ghost assigned lloyd Aug 2, 2012
@seanmonstar
Copy link
Contributor

just a general question regarding logging deprecating warnings: is it better to console.warn() deprecation warnings?

@seanmonstar
Copy link
Contributor

otherwise, looks good from here

@shane-tomlinson
Copy link
Author

@seanmonstar - excellent suggestion. According to MDN, IE down to 8 supports console.warn - https://developer.mozilla.org/en-US/docs/DOM/console.warn

Will update.

shane-tomlinson pushed a commit that referenced this pull request Aug 10, 2012
Merge pull request #2202 from mozilla/issue_1438_tos_priv
cc0ba1c 
Add a console message if only one of privacyPolicy or termsOfService is defined.

Adding @seanmonstar's suggestion to the PR which already got a "looks good from here"

close #1438
@shane-tomlinson shane-tomlinson merged commit cc0ba1c into dev Aug 10, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@lloyd lloyd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shane-tomlinson @seanmonstar @lloyd