This repository has been archived by the owner on May 10, 2019. It is now read-only.
KPI updates for reset password flow #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Add the following new events to the KPI event stream: * user.reset_password_staged * user.reset_password_confirmed * user.reverify_email_staged * user.reverify_email_confirmed There was a spelling error in the user.user_confirmed, it was previously user.user_confrimed.
|
The changes look good to me, and I've confirmed that both sets of new events (reset_password and reverify_email) are emitted during the respective flows. |
|
verified train-2012.10.12 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following new events to the KPI event stream:
There was also a spelling error in user.user_confirmed, it was previously user.user_confrimed.
issue #2281