Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

Issue 2515 fixup absolute path #2516

Merged
merged 2 commits into from Sep 25, 2012
Merged

Issue 2515 fixup absolute path #2516

merged 2 commits into from Sep 25, 2012

Conversation

shane-tomlinson
Copy link

This is a two commit PR.

  1. The first commit addresses issue error when returnTo is empty or set to "/" #2515 - error when returnTo is empty or set to "/"
  2. The second commit is a huge cleanup of the dialog.js tests.

issue #2515

Shane Tomlinson added 2 commits September 24, 2012 13:30
Allow returnTo to be "/"
0292f84 
Disallow "/" for:
* siteLogo
* termsOfService
* privacyPolicy
Clean up the dialog unit tests.
1d1c7dd 
* Further use of the testExpectGetFailure, testExpectGetSuccess, testRelativeURLNotAllowed and testMustBeAbsolutePath
@ghost ghost assigned fmarier Sep 24, 2012
@fmarier
Copy link
Contributor

fmarier commented Sep 24, 2012

That fix looks good to me. r+

For the record, this bug was introduced (by me) in #2480 / 60d61f5.

shane-tomlinson pushed a commit that referenced this pull request Sep 25, 2012
Merge pull request #2516 from mozilla/issue_2515_fixupAbsolutePath
536ccde 
Issue 2515 fixup absolute path

close #2515
@shane-tomlinson shane-tomlinson merged commit 536ccde into dev Sep 25, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@fmarier fmarier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shane-tomlinson @fmarier