This repository has been archived by the owner on May 10, 2019. It is now read-only.
ISSUE 3838 - desktop dialog text is quite compressed, especially the site name and "sign in to..." FIX #4103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
issue #3838 |
|
@Iaincal sorry this hasn't moved. Once we've gotten a release out the door, I'll be happy to take a look at this code. |
|
Subjective, but I'm going to claim that we shouldn't second-guess the font's own metrics. Removing the letter-spacing rule entirely. It looks subjectively better in my own testing. Thanks, @Iaincal! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the line spacing to CSS from -1px to .75px.