Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_sources do not block intsllastion from other sources #810

Closed
akiralight opened this issue Oct 14, 2021 · 7 comments
Closed

install_sources do not block intsllastion from other sources #810

akiralight opened this issue Oct 14, 2021 · 7 comments

Comments

@akiralight
Copy link

I want to only allow extensions to be installed from our internal local website and block installation from other sources (including addons.mozilla.org). I specify the ExtensionSettings policy as follows:
{
"*": {
"blocked_install_message": "My message",
"install_sources": ["https://website.local"],
"allowed_types": ["extension"]
}
}
Waiting: only xpi files from https://website.local allowed to install in Firefox, others will be blocked.
Reality: I can still install any extensions from https://addons.mozilla.org

Why is this happening and how to get the desired result?

@mkaply
Copy link
Collaborator

mkaply commented Oct 14, 2021

It looks like there is a bug where addons.mozilla.org is still being allowed when install_sources is specified. I'm investigating.

Is there a limited number of addons that you want to install from your website? If so, I can give you a workaround.

Also, install_sources needs to be a match pattern, so it should be https://website.local/*

@akiralight
Copy link
Author

Do you mean ID-based addon installation via ExtensionSettings? This option was also considered. But there is another problem. When the ExtensionSettings are defined, all existing Firefox extensions are disabled and cannot be enabled by the user. It is unacceptable for us to disable extensions previously installed through "Estensions" policy (like Software\Policies\Mozilla\Firefox\Extensions\Install\1 = "https://.../somefile.xpi"). It would be nice if we could disable the "Extensions" policy and enable the "ExtensionSettings" policy, and all previously installed extensions remain enabled. But I have not found a way to do this.

@mkaply
Copy link
Collaborator

mkaply commented Oct 18, 2021

I'll get this bug fixed ASAP and you should be good

Another thought is you could just block addons.mozilla.org via the WebsiteFilter

@Selkie44
Copy link

Hello,
Any news on this bug? For a business that wants to allow only internal add-ons and prevent users from adding community extensions this is the easiest way. Otherwise, each extension must be declared with its ID and it is much more restrictive.

@mkaply
Copy link
Collaborator

mkaply commented Dec 19, 2021

The code is in review right now. Should have it soon

@kleener
Copy link

kleener commented Apr 6, 2022

Hi,
what is the status?
Is it already live?

@mkaply
Copy link
Collaborator

mkaply commented Apr 6, 2022

Yes, this bug was finally fixed in Firefox 99. Unfortunately we couldn't backport to the ESR, but it will be in ESR 102.

@mkaply mkaply closed this as completed Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants