Fix bug 1602374: Sort Priority and Unreviewed descendingly on first c…

…lick (#1518)
mozilla · Dec 12, 2019 · 53bc0f6 · 53bc0f6
1 parent 4ee4356
commit 53bc0f6
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 11 deletions.
diff --git a/pontoon/base/static/css/style.css b/pontoon/base/static/css/style.css
@@ -187,13 +187,15 @@ th {
   position: absolute;
 }
 
-.table-sort th.asc i:after {
+.table-sort th.asc i:after,
+.table-sort th.desc.inverted i:after {
   content: "";
   display: inline-block;
   margin-top: 5px;
 }
 
-.table-sort th.desc i:after {
+.table-sort th.desc i:after,
+.table-sort th.asc.inverted i:after {
   content: "";
   display: inline-block;
   margin-top: -5px;

diff --git a/pontoon/base/static/js/table.js b/pontoon/base/static/js/table.js
@@ -168,7 +168,7 @@ var Pontoon = (function (my) {
 
             // Sort by unreviewed state
             } else if (node.is('.unreviewed-status')) {
-              return (getUnreviewed(a) - getUnreviewed(b)) * dir;
+              return (getUnreviewed(b) - getUnreviewed(a)) * dir;
 
             // Sort by deadline
             } else if (node.is('.deadline')) {
@@ -190,7 +190,7 @@ var Pontoon = (function (my) {
 
             // Sort by priority
             } else if (node.is('.priority')) {
-              return (getPriority(a) - getPriority(b)) * dir;
+              return (getPriority(b) - getPriority(a)) * dir;
 
             // Sort by enabled state
             } else if (node.is('.check')) {

diff --git a/pontoon/localizations/templates/localizations/widgets/resource_list.html b/pontoon/localizations/templates/localizations/widgets/resource_list.html
@@ -14,12 +14,12 @@
         {% endif %}
 
         {% if priority %}
-        <th class="priority">Priority<i class="fa"></i></th>
+        <th class="priority inverted">Priority<i class="fa"></i></th>
         {% endif %}
 
         <th class="latest-activity">Latest Activity<i class="fa"></i></th>
         <th class="progress">Progress<i class="fa"></i></th>
-        <th class="unreviewed-status" title="Unreviewed suggestions"><span class="fa fa-lightbulb"></span><i class="fa"></i></th>
+        <th class="unreviewed-status inverted" title="Unreviewed suggestions"><span class="fa fa-lightbulb"></span><i class="fa"></i></th>
       </tr>
     </thead>
     <tbody>

diff --git a/pontoon/projects/templates/projects/widgets/project_list.html b/pontoon/projects/templates/projects/widgets/project_list.html
@@ -9,10 +9,10 @@
       <tr>
         <th class="name asc">Project<i class="fa"></i></th>
         <th class="deadline">Deadline<i class="fa"></i></th>
-        <th class="priority">Priority<i class="fa"></i></th>
+        <th class="priority inverted">Priority<i class="fa"></i></th>
         <th class="latest-activity">Latest Activity<i class="fa"></i></th>
         <th class="progress">Progress<i class="fa"></i></th>
-        <th class="unreviewed-status" title="Unreviewed suggestions"><span class="fa fa-lightbulb"></span><i class="fa"></i></th>
+        <th class="unreviewed-status inverted" title="Unreviewed suggestions"><span class="fa fa-lightbulb"></span><i class="fa"></i></th>
         {% if request %}
           <th class="all-strings">Number of Strings<i class="fa"></i></th>
           <th class="check">Request<i class="fa"></i></th>

diff --git a/pontoon/tags/templates/tags/widgets/tag_list.html b/pontoon/tags/templates/tags/widgets/tag_list.html
@@ -7,10 +7,10 @@
     <thead>
       <tr>
         <th class="tag asc">Tag<i class="fa"></i></th>
-        <th class="priority">Priority<i class="fa"></i></th>
+        <th class="priority inverted">Priority<i class="fa"></i></th>
         <th class="latest-activity">Latest Activity<i class="fa"></i></th>
         <th class="progress">Progress<i class="fa"></i></th>
-        <th class="unreviewed-status" title="Unreviewed suggestions"><span class="fa fa-lightbulb"></span><i class="fa"></i></th>
+        <th class="unreviewed-status inverted" title="Unreviewed suggestions"><span class="fa fa-lightbulb"></span><i class="fa"></i></th>
       </tr>
     </thead>
     <tbody>

diff --git a/pontoon/teams/templates/teams/widgets/team_list.html b/pontoon/teams/templates/teams/widgets/team_list.html
@@ -10,7 +10,7 @@
         <th class="population">Speakers<i class="fa"></i></th>
         <th class="latest-activity">Latest Activity<i class="fa"></i></th>
         <th class="progress">Progress<i class="fa"></i></th>
-        <th class="unreviewed-status" title="Unreviewed suggestions"><span class="fa fa-lightbulb"></span><i class="fa"></i></th>
+        <th class="unreviewed-status inverted" title="Unreviewed suggestions"><span class="fa fa-lightbulb"></span><i class="fa"></i></th>
         {% if request %}
           <th class="check">Request<i class="fa"></i></th>
         {% endif %}