Fix bug 1604843: Add support for SYSTRAN Translate service #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathjazz
force-pushed
the
bug-1604843-systran
branch
from
6037355
to
a347080
Compare
|
I glanced at the results on stage, and there's one where I don't know why, https://mozilla-pontoon-staging.herokuapp.com/de/firefox/all-resources/?string=192281. There's a leading |
Pike
requested changes
Jul 20, 2020
| @@ -0,0 +1,53 @@ | |||
| # Generated by Django 2.2.13 on 2020-07-13 16:47 | |||
There was a problem hiding this comment.
Minor comment, maybe give this one a semantic name?
| blank=True, | ||
| help_text=""" | ||
| SYSTRAN Profile UUID to specify the engine trained on the en-locale language pair. | ||
| """, |
There was a problem hiding this comment.
We talked about this on the call, we shouldn't make admins enter this, if it can be avoided. You mentioned there would be an API to query this?
Not terribly bound to where we store this.
Including support for custom engines (profiles).
mathjazz
force-pushed
the
bug-1604843-systran
branch
from
dfd63fb
to
649277e
Compare
Pike
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch is deployed to stage. Systran is only enabled for German, French and Spanish (es and es-ES).
Followups: