Fix bug 1692423: Replace broken CSS compressor with a no-op compressor #1868
Conversation
The + and - operators in CSS calc() must be surrounded by whitespace: https://developer.mozilla.org/en-US/docs/Web/CSS/calc()#notes The yuglify CSS compressor we use removes them and breaks CSS. I tried yuicompressor instead, which has the same bug: yui/yuicompressor#59 Other CSS compressors I've checked look (even more) outdated. I haven't tested any. The only other instance of calc() in our code uses - instead of +, which is fine.
mathjazz
changed the title
|
I mentioned this on matrix, I don't think we should constrain our CSS by bugs in that pipeline. In particular for CSS, where there's just not much to win, IMHO. https://django-pipeline.readthedocs.io/en/latest/compressors.html#no-op-compressors suggests that we can just use a no-op css compressor to cat the files together. If we're really concerned, maybe there's a trick to compress the cat'ed css files with a transfer encoding. |
This reverts commit 26db0f9.
…), which are significant: https://developer.mozilla.org/en-US/docs/Web/CSS/calc()#notes Since none of the CSS compressors seems to be prone to this bug, we drop them.
Agreed. I've tested this on stage and it works as expected. |
pontoon/settings/base.py
Outdated
| @@ -476,6 +476,7 @@ def path(*args): | |||
| "STYLESHEETS": PIPELINE_CSS, | |||
| "JAVASCRIPT": PIPELINE_JS, | |||
| "JS_COMPRESSOR": "pipeline.compressors.terser.TerserCompressor", | |||
| "CSS_COMPRESSOR": "pipeline.compressors.terser.NoopCompressor", | |||
There was a problem hiding this comment.
That one doesn't exist, it's in the parent, https://github.com/jazzband/django-pipeline/blob/master/pipeline/compressors/__init__.py#L256
Weird that that does something constructive on stage
mathjazz
changed the title
The + and - operators in CSS calc() must be surrounded by whitespace:
https://developer.mozilla.org/en-US/docs/Web/CSS/calc()#notes
The yuglify CSS compressor we use removes them and breaks CSS.
I tried yuicompressor instead, which has the same bug: yui/yuicompressor#59
Other CSS compressors I've checked look (even more) outdated. I haven't tested any.
The only other instance of calc() in our code uses - instead of +, which is fine.