-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pretranslation monitoring: Insights page #2932
Pretranslation monitoring: Insights page #2932
Conversation
02aab39
to
f4f5355
Compare
Investigating the funkiness of the sl (and All) charts. Seems like an issue with the X-axis. |
No familiar with the chart library, but would it be possible to have a "select/deselect all" in the legend (or have the "double click = disable all but this" behavior)? |
Yeah, took me about a second of using the chart to had the same wish. :) We can render the legend manually in a custom div, which allows for such customization. It will also allow us to align both charts horizontally and enable to scale better when more locales / projects are added. I'll give it a shot. |
Done. Cmd + Click or Alt + Click shows only the clicked item. Let me know how it feels. |
Works great. Doesn't feel like it needs a "select all", since you can always reload the page to go back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor JS issues, see inline. Otherwise fine.
Fixed percentages in db32055. Honestly, I'm not sure I like this approach better, because the values are actual percentages. |
Would recommend that you spin off the "Upgrade Chart.js" todo item into a separately tracked issue, so it's not blocking this PR. |
- Aligns both charts - Scales well for longer lists of Teams and Projects
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
59890a2
to
ae6623d
Compare
Part 3/3 of #2923.
This PR adds the third and final part of Pretranslation Monitoring, namely the new "Insights" page.
The PR is based on #2929, the first commit specific to this PR is 86283b6, which (together with e48f0d0) is just a preparation for the actual changes introduced in f4f5355.
It is deployed to stage:
https://mozilla-pontoon-staging.herokuapp.com/insights/
TODO: