Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Django to 4.2.11 #3183

Merged
merged 16 commits into from
Apr 24, 2024
Merged

Upgrade Django to 4.2.11 #3183

merged 16 commits into from
Apr 24, 2024

Conversation

mathjazz
Copy link
Collaborator

@mathjazz mathjazz commented Apr 22, 2024

Fix #3059.

The first commit addresses the deprecation warning in Django 3.2.

The next batch of commits updates Django dependencies.

Each Upgrade Django to 4.X.Y commit only updates Django. Commits that follow address issues on build time, on run time and in tests.

The patch is currently deployed to stage for testing. I don't see any issues in the app or sync.

The main (and perhaps only) breaking change for existing deployments is that the ALLOWED_HOSTS variable needs to be explicitly set. It is no longer retrieved from the SITE_URL variable.

Copy link
Member

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable, and if tests pass and it runs fine on staging, it's probably fine.

pontoon/base/utils.py Show resolved Hide resolved
@mathjazz mathjazz merged commit 3d51fba into mozilla:main Apr 24, 2024
5 checks passed
@mathjazz mathjazz deleted the 3059-django-4.2 branch April 24, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Django to 4.2 (LTS)
2 participants