Added capability to mention users by username #3253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathjazz
reviewed
Jun 7, 2024
| @@ -685,6 +685,7 @@ def get_users(request): | |||
| "gravatar": u.gravatar_url(44), | |||
| "name": u.name_or_email, | |||
| "url": u.profile_url, | |||
| "username": u.profile.username, | |||
There was a problem hiding this comment.
This will result in N additional DB queries, where N is the number of users (currently close to 20k on production), which makes the /get-users/ request quite slow compared to its current performance.
This happens because the username is stored in a separate table (UserProfile rather than User). The issue can be mitigated by using prefetch_related().
You can debug DB queries using debug_sql().
There was a problem hiding this comment.
That's a million times faster! Thank you for pointing that out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2625
Added functionality for mentioning users by typing their username instead of only by display name. This feature was achieved by modifying the
/get-users/API to return the usernames of all UserProfile objects in addition to the preexisting fields. The suggestedUsers filter function was modified to first check for a matching username (if it exists), then checking for a matching display name.To reproduce results: After starting up the server, navigate to any team/project. Select any string that has an existing translation. Click the "COMMENT" button, and then inside the text editor field, type
@[any string of letters]to display a list of users whose display name or username contains that string of letters. If you know a specific user's username, try typing their full username or a subset of it, and their profile will appear just as if you typed their display name instead.