Skip to content
This repository has been archived by the owner on Jun 29, 2018. It is now read-only.

CSS support for styling players #378

Open
binarykitchen opened this issue Feb 5, 2014 · 7 comments
Open

CSS support for styling players #378

binarykitchen opened this issue Feb 5, 2014 · 7 comments

Comments

@binarykitchen
Copy link

I wonder if it's easy to style the video players easily with CSS on popcorn-js?

Most 3d party video players like videojs place new div elements for the control bar, the play button etc so that it becomes easier to syle.

Does popcorn-js have/allow this?

@binarykitchen
Copy link
Author

Or it is safe to wrap the popcorn video player with another video player library like videojs?

@ScottDowne
Copy link
Contributor

Yeah it should work with videojs, something else, or your own custom
controls.
On 2014-02-05 1:15 AM, "Michael Heuberger" notifications@github.com wrote:

Or it is safe to wrap the popcorn video player with another video player
library like videojs?

Reply to this email directly or view it on GitHubhttps://github.com//issues/378#issuecomment-34140515
.

@binarykitchen
Copy link
Author

Thanks! Have you tried with own custom controls yet?

@ScottDowne
Copy link
Contributor

The controls use in popcorn.webmaker.org are custom. You'll see them after
publishing a project. While it would be possible to use them they are
designed with popcorn.webmaker in mind.
On 2014-02-05 7:36 AM, "Michael Heuberger" notifications@github.com wrote:

Thanks! Have you tried with own custom controls yet?

Reply to this email directly or view it on GitHubhttps://github.com//issues/378#issuecomment-34161886
.

@binarykitchen
Copy link
Author

Hmmm... interesting, thanks.

But how come nobody has tried to add stylish controls yet for such a big project?

@ScottDowne
Copy link
Contributor

Popcorn.js itself currently doesn't set out to solve the problem of custom
controls, because others have solved that. I can see a lot of value in
making it as easy as possible to use other controls plugins, so if you find
it hard to use videojs or others, that's something we can fix.

On 5 February 2014 07:54, Michael Heuberger notifications@github.comwrote:

Hmmm... interesting, thanks.

But how come nobody has tried to add stylish controls yet for such a big
project?

Reply to this email directly or view it on GitHubhttps://github.com//issues/378#issuecomment-34162938
.

@binarykitchen
Copy link
Author

I see and that makes sense. But it might be dangerous using 3rd party libraries like videojs because they can mess up with the event handling. When popcorn listens to i.E. play events and videojs is manipulating these, then things can go wrong ... I need some kind of assurance that both go well together.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants